[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bcalligra=5D_libs/kotext/opendocument/tests=3A_Don?=
From:       Sebastian Sauer <sebastian.sauer () kdab ! com>
Date:       2011-06-21 18:07:25
Message-ID: 20110621180725.836F4A60A4 () git ! kde ! org
[Download RAW message or body]

Git commit 5d4aeacd929cd950fb4e260406ad9e69008d3021 by Sebastian Sauer.
Committed on 21/06/2011 at 20:05.
Pushed by sebsauer into branch 'master'.

Don't fill the harddisc if the testLoading or testSaving unittests fail.

M  +7    -0    libs/kotext/opendocument/tests/TestLoading.cpp     

http://commits.kde.org/calligra/5d4aeacd929cd950fb4e260406ad9e69008d3021

diff --git a/libs/kotext/opendocument/tests/TestLoading.cpp \
b/libs/kotext/opendocument/tests/TestLoading.cpp index 5b16f63..7e1f305 100644
--- a/libs/kotext/opendocument/tests/TestLoading.cpp
+++ b/libs/kotext/opendocument/tests/TestLoading.cpp
@@ -1175,6 +1175,8 @@ void TestLoading::testLoading()
     Q_UNUSED(showDocument);
 //    showDocument(actualDocument);
 //    showDocument(expectedDocument);
+
+    /* don't fill the harddisc
     if (!documentsEqual) {
         testName.replace('/', '_');
         QFile file1("failed-loading-" + testName + "-actual");
@@ -1190,6 +1192,8 @@ void TestLoading::testLoading()
             file2.close();
         }
     }
+    */
+
     if (testcase.indexOf("Tables/") > 0)
         QEXPECT_FAIL("", "Tables not supported yet", Abort);
     delete actualDocument;
@@ -1221,6 +1225,7 @@ void TestLoading::testSaving()
 
     bool documentsEqual = compareDocuments(savedDocument, expectedDocument);
 
+    /* don't fill the harddisc
     if (!documentsEqual) {
         testName.replace('/', '_');
         QFile file1("failed-saving-" + testName + "-actual");
@@ -1236,6 +1241,8 @@ void TestLoading::testSaving()
             file2.close();
         }
     }
+    */
+
     delete actualDocument;
     delete expectedDocument;
     delete savedDocument;


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic