From kde-commits Mon Jun 06 01:52:11 2011 From: Giorgos Kylafas Date: Mon, 06 Jun 2011 01:52:11 +0000 To: kde-commits Subject: KDE/kdemultimedia/juk Message-Id: <20110606015211.BED71AC783 () svn ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=130732518424926 SVN commit 1235482 by kylafas: juk: load search playlists even when containing empty patterns. When a new search playlist is created, we are allowed to not fill any "search lines" with our criteria. This means that when a new search playlist is created/saved, it may contain search components with empty patterns. However, when loading a search playlist from disk, we signal an error if we read an empty search pattern. As a result, the playlist does not get loaded and JuK gives the impression that it does not save the search playlists. Since we are presented with two search lines when creating a new search playlist (see AdvancedSearchDialog's ctor), the above has a rather high chance of happening. So, upon loading, we should not consider the presense of empty patterns as an error. M +0 -3 playlistsearch.cpp --- trunk/KDE/kdemultimedia/juk/playlistsearch.cpp #1235481:1235482 @@ -318,9 +318,6 @@ >> columns >> mode; - if(pattern.isEmpty()) - throw BICStreamException(); - if(patternSearch) c = PlaylistSearch::Component(QRegExp(pattern), columns); else