[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg
From:       Vishesh Yadav <vishesh3y () gmail ! com>
Date:       2011-06-01 1:38:24
Message-ID: 20110601013824.03D6CAC779 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1234382 by visheshyadav:

Cleaned up code.

 M  +0 -1      branchdialog.h  
 M  +0 -2      commitdialog.cpp  
 U             commitdialog.h  
 M  +4 -2      fileviewhgplugin.cpp  
 U             fileviewhgplugin.h  
 M  +2 -3      hgwrapper.cpp  
 U             hgwrapper.h  
 M  +0 -1      renamedialog.cpp  
 U             renamedialog.h  
 M  +2 -4      statuslist.cpp  


--- branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg/branchdialog.h #1234381:1234382
@@ -32,4 +32,3 @@
 
 #endif // HGBRANCHTAG_H
 
-
--- branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg/commitdialog.cpp #1234381:1234382
@@ -30,7 +30,6 @@
 #include <QtGui/QGroupBox>
 #include <QtCore/QStringList>
 #include <QtGui/QActionGroup>
-#include <QDebug>
 #include <kurl.h>
 #include <kpushbutton.h>
 #include <klocale.h>
@@ -167,7 +166,6 @@
 
 void HgCommitDialog::slotItemSelectionChanged(const char status, const QString &fileName)
 {
-    qDebug() << "Caught signal itemSelectionChanged from HgStatusList";
     m_fileDiffDoc->setReadWrite(true);
     m_fileDiffDoc->setModified(false);
     m_fileDiffDoc->closeUrl(false);
--- branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg/fileviewhgplugin.cpp #1234381:1234382
@@ -24,7 +24,7 @@
 #include <kaction.h>
 #include <kicon.h>
 #include <klocale.h>
-#include <QtCore/QDebug>
+#include <kdebug.h>
 
 #include <KPluginFactory>
 #include <KPluginLoader>
@@ -124,6 +124,7 @@
             char currentStatus = buffer[0];
             QString currentFile = currentLine.mid(2);
             currentFile = currentFile.trimmed();
+            kDebug() << "Hg/FileStatus" << currentStatus << " " << currentFile;
             if (currentFile.startsWith(relativePrefix)) {
                 VersionState vs = NormalVersion;
                 switch (currentStatus) {
@@ -309,7 +310,8 @@
 {
     if ((exitStatus != QProcess::NormalExit) || (exitCode != 0)) {
         emit errorMessage(m_errorMsg);
-    } else {
+    }
+    else {
         m_contextItems.clear();
         emit operationCompletedMessage(m_operationCompletedMsg);
         emit versionStatesChanged();
--- branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg/hgwrapper.cpp #1234381:1234382
@@ -19,8 +19,6 @@
 
 #include "hgwrapper.h"
 
-#include <QDebug>
-
 HgWrapper* HgWrapper::m_instance = 0;
 bool HgWrapper::m_pendingOperation = 0;
 
@@ -80,8 +78,9 @@
 QString HgWrapper::getBaseDir(const QString& directory)
 {
     m_pendingOperation = true;
-    if(!directory.isEmpty())
+    if (!directory.isEmpty()) {
         setWorkingDirectory(directory);
+    }
     start(QLatin1String("hg root"));
     QString hgBaseDir;
     while (waitForReadyRead()) {
--- branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg/renamedialog.cpp #1234381:1234382
@@ -26,7 +26,6 @@
 #include <QtGui/QVBoxLayout>
 #include <QtGui/QLabel>
 #include <QtGui/QFrame>
-#include <QDebug>
 
 HgRenameDialog::HgRenameDialog(const KFileItem& source, QWidget* parent):
     KDialog(parent, Qt::Dialog), 
--- branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg/statuslist.cpp #1234381:1234382
@@ -22,11 +22,9 @@
 
 #include <QtGui/QVBoxLayout>
 #include <QtCore/QStringList>
-#include <QDebug>
 #include <QHeaderView>
 #include <klocale.h>
 
-
 HgStatusList::HgStatusList(QWidget *parent):
     QGroupBox(parent)
 {
@@ -55,7 +53,6 @@
 
 void HgStatusList::itemSelectionChangedSlot()
 {
-    qDebug() << "Emitting itemSelectionChanged from HgStatusList";
     emit itemSelectionChanged(
             m_statusTable->item(m_statusTable->currentRow(), 1)->text()[0].toLatin1(),
             m_statusTable->item(m_statusTable->currentRow(), 2)->text() );
@@ -139,8 +136,9 @@
     if (nChecked == nRowCount) {
         files.clear();
     }
-    if (nChecked)
+    if (nChecked) {
         return true;
+    }
     return false;
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]