[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bkdelibs=5D_kioslave/http=3A_-_Force_NTLM_v1_mode_si?=
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2011-05-03 13:33:49
Message-ID: 20110503133349.500E0A60AE () git ! kde ! org
[Download RAW message or body]

Git commit 6eadfd17c49e136e47b5a3788a12b7f59e4e4af3 by Dawit Alemayehu.
Committed on 03/05/2011 at 15:24.
Pushed by adawit into branch 'master'.

- Force NTLM v1 mode since KNTLM does not yet have support for "NTLM2 Session Response"
  which is different from NTLM v2. We cannot do NTLM v2 because its setup and use is
  rather complicated. See http://davenport.sourceforge.net/ntlm.html.
(cherry picked from commit 6531e99661e4e4f8827bc88bac8b9a0e79fb6ce4)

M  +2    -1    kioslave/http/httpauthentication.cpp     

http://commits.kde.org/kdelibs/6eadfd17c49e136e47b5a3788a12b7f59e4e4af3

diff --git a/kioslave/http/httpauthentication.cpp b/kioslave/http/httpauthentication.cpp
index cfe898f..bf4f01d 100644
--- a/kioslave/http/httpauthentication.cpp
+++ b/kioslave/http/httpauthentication.cpp
@@ -607,7 +607,8 @@ void KHttpNtlmAuthentication::generateResponse(const QString &_user, const QStri
 
         m_forceKeepAlive = true;
         const QByteArray challenge = QByteArray::fromBase64(m_challenge[0]);
-        if (!KNTLM::getAuth(buf, challenge, user, password, domain, QHostInfo::localHostName())) {
+        if (!KNTLM::getAuth(buf, challenge, user, password, domain, QHostInfo::localHostName(),
+                            (KNTLM::Force_V1 | KNTLM::Add_LM))) {
             kWarning(7113) << "Error while constructing Type 3 NTLM authentication request";
             m_isError = true;
             return;


[prev in list] [next in list] [prev in thread] [next in thread]