[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bphonon-gstreamer=5D_gstreamer=3A_make_warnings_that?=
From:       Harald Sitter <sitter () kde ! org>
Date:       2011-04-09 9:01:57
Message-ID: 20110409090157.03EBBA60B0 () git ! kde ! org
[Download RAW message or body]

Git commit 52abe397377671ecb4e6246983e6b8788aa1123c by Harald Sitter.
Committed on 09/04/2011 at 11:00.
Pushed by sitter into branch 'master'.

make warnings that cannot be solved for 4.5 not mention 4.5

M  +1    -1    gstreamer/effectmanager.cpp     
M  +1    -1    gstreamer/mediaobject.cpp     

http://commits.kde.org/phonon-gstreamer/52abe397377671ecb4e6246983e6b8788aa1123c

diff --git a/gstreamer/effectmanager.cpp b/gstreamer/effectmanager.cpp
index ff29b24..78a0927 100644
--- a/gstreamer/effectmanager.cpp
+++ b/gstreamer/effectmanager.cpp
@@ -85,7 +85,7 @@ EffectManager::EffectManager(Backend *backend)
                     m_audioEffectList.append(effect);
 
 #ifdef __GNUC__
-#warning TODO 4.5 - get rid of equalizer name mapping (also see audioeffect.cpp)
+#warning TODO - get rid of equalizer name mapping (also see audioeffect.cpp)
 #endif
                     // Map the GStreamer name to the name used by Xine, to allow
                     // API consumers that think KEqualizer is a persistant name
diff --git a/gstreamer/mediaobject.cpp b/gstreamer/mediaobject.cpp
index 01f8bd6..2759ed9 100644
--- a/gstreamer/mediaobject.cpp
+++ b/gstreamer/mediaobject.cpp
@@ -739,7 +739,7 @@ void MediaObject::setState(State newstate)
 
     case Phonon::PlayingState:
 #ifdef __GNUC__
-#warning TODO 4.5
+#warning TODO - drop m_resetNeeded (messes with one-time-connection URLs)
 #endif
         // TODO 4.5: drop m_resetNeeded completely and use live connections, whatever
         // those might be.

[prev in list] [next in list] [prev in thread] [next in thread]