[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdemultimedia/kmix
From:       Lamarque Souza <lamarque () gmail ! com>
Date:       2011-04-04 2:28:38
Message-ID: 20110404022838.6F984AC8CE () svn ! kde ! org
[Download RAW message or body]

SVN commit 1227025 by lvsouza:

Fix memory leak when DialogSelectMaster dialogs are closed.
Thanks Felix Berger for this patch.

BUG: 260926
FIXED-IN: 4.6.2


 M  +2 -1      apps/kmix.cpp  
 M  +1 -1      gui/kmixdockwidget.cpp  


--- trunk/KDE/kdemultimedia/kmix/apps/kmix.cpp #1227024:1227025
@@ -1133,7 +1133,8 @@
 void KMixWindow::slotSelectMaster()
 {
     DialogSelectMaster* dsm = new DialogSelectMaster(Mixer::getGlobalMasterMixer());
-    if (dsm) dsm->show();
+    dsm->setAttribute(Qt::WA_DeleteOnClose, true);
+    dsm->show();
 }
 
 void KMixWindow::newMixerShown(int /*tabIndex*/ ) {
--- trunk/KDE/kdemultimedia/kmix/gui/kmixdockwidget.cpp #1227024:1227025
@@ -175,10 +175,10 @@
 void KMixDockWidget::selectMaster()
 {
    DialogSelectMaster* dsm = new DialogSelectMaster(m_mixer);
+   dsm->setAttribute(Qt::WA_DeleteOnClose, true);
    connect ( dsm, SIGNAL(newMasterSelected(QString&, QString&)), SLOT( \
handleNewMaster(QString&, QString&)) );  connect ( dsm, \
SIGNAL(newMasterSelected(QString&, QString&)), SIGNAL( newMasterSelected()) );  \
                dsm->show();
-    // !! The dialog is modal. Does it delete itself?
 }
 
 


[prev in list] [next in list] [prev in thread] [next in thread]