[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bkdelibs/KDE/4=2E6=5D_kdeui/icons=3A_Reverting_commi?=
From:       "Lamarque V.Souza" <lamarque () gmail ! com>
Date:       2011-03-28 2:46:55
Message-ID: 20110328024655.AA8D5A609B () git ! kde ! org
[Download RAW message or body]

Git commit 44401745dbf91e8212b1f5367d67956c921d993e by Lamarque V. Souza.
Committed on 28/03/2011 at 04:45.
Pushed by lvsouza into branch 'KDE/4.6'.

Reverting commit c956b436f63fa957a866ad049f7dbf14ee708968 since it does
not solve the problem in question.

M  +1    -2    kdeui/icons/kiconeffect.cpp     

http://commits.kde.org/kdelibs/44401745dbf91e8212b1f5367d67956c921d993e

diff --git a/kdeui/icons/kiconeffect.cpp b/kdeui/icons/kiconeffect.cpp
index f78a2dd..3bd5e49 100644
--- a/kdeui/icons/kiconeffect.cpp
+++ b/kdeui/icons/kiconeffect.cpp
@@ -187,8 +187,7 @@ QString KIconEffect::fingerprint(int group, int state) const
             cached += d->color2[group][state].name();
         }
 
-        // Using deep copy since cached is a local variable.
-        d->key[group][state] = QString(cached.data());
+        d->key[group][state] = cached;
     }
 
     return cached;

[prev in list] [next in list] [prev in thread] [next in thread]