[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bkdelibs/KDE/4=2E6=5D_plasma=3A_after_applet=27s_dat?=
From:       Marco Martin <notmart () gmail ! com>
Date:       2011-03-02 21:09:18
Message-ID: 20110302210918.B990EA60C9 () git ! kde ! org
[Download RAW message or body]

Git commit 9c9bf7286d74f3df64958607fd7b7251231cb455 by Marco Martin.
Committed on 02/03/2011 at 22:04.
Pushed by mart into branch 'KDE/4.6'.

after applet's dataupdated is called, dirty=false

in DataEnginePrivate::connectSource, if it's an immediate call, and \
QMetaObject::invokeMethod(visualization, "dataUpdated" is called, means the datacontainers' dirty bit \
must be set to false, otherwise we will get two subsequent dataUpdated

can it have countereffects?

CCMAIL:plasma-devel@kde.org

M  +1    -0    plasma/dataengine.cpp     

http://commits.kde.org/kdelibs/9c9bf7286d74f3df64958607fd7b7251231cb455

diff --git a/plasma/dataengine.cpp b/plasma/dataengine.cpp
index b28658f..7be42f9 100644
--- a/plasma/dataengine.cpp
+++ b/plasma/dataengine.cpp
@@ -671,6 +671,7 @@ void DataEnginePrivate::connectSource(DataContainer *s, QObject *visualization,
         QMetaObject::invokeMethod(visualization, "dataUpdated",
                                   Q_ARG(QString, s->objectName()),
                                   Q_ARG(Plasma::DataEngine::Data, s->data()));
+        s->d->dirty = false;
     }
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]