[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bkde-runtime=5D_phonon/platform=5Fkde=3A_nice_code_i?=
From:       Harald Sitter <sitter () kde ! org>
Date:       2011-03-01 0:15:07
Message-ID: 20110301001507.2B8EBA60CD () git ! kde ! org
[Download RAW message or body]

Git commit 54b72376d8b7e97b063f683daf85182e6b5cf5a8 by Harald Sitter.
Committed on 01/03/2011 at 01:07.
Pushed by sitter into branch 'master'.

nice code is the first step to world piece

(0 == foo) == (!foo)

M  +3    -3    phonon/platform_kde/kdeplatformplugin.cpp     

http://commits.kde.org/kde-runtime/54b72376d8b7e97b063f683daf85182e6b5cf5a8

diff --git a/phonon/platform_kde/kdeplatformplugin.cpp b/phonon/platform_kde/kdeplatformplugin.cpp
index d82932b..1df2be9 100644
--- a/phonon/platform_kde/kdeplatformplugin.cpp
+++ b/phonon/platform_kde/kdeplatformplugin.cpp
@@ -131,14 +131,14 @@ QObject *KdePlatformPlugin::createBackend(KService::Ptr newService)
         errorReason = KLibLoader::self()->lastErrorMessage();
     } else {
         QObject *backend = factory->create<QObject>();
-        if (0 == backend) {
+        if (!backend) {
             errorReason = i18n("create method returned 0");
         }
     }
 #else
     QObject *backend = newService->createInstance<QObject>(0, QVariantList(), &errorReason);
 #endif
-    if (0 == backend) {
+    if (!backend) {
         const QLatin1String suffix("/phonon_backend/");
         const QStringList libFilter(newService->library() + QLatin1String(".*"));
         foreach (QString libPath, QCoreApplication::libraryPaths()) {
@@ -156,7 +156,7 @@ QObject *KdePlatformPlugin::createBackend(KService::Ptr newService)
             }
         }
     }
-    if (0 == backend) {
+    if (!backend) {
         kError(600) << "Can not create backend object from factory for " <<
             newService->name() << ", " << newService->library() << ":\n" << errorReason;
 

[prev in list] [next in list] [prev in thread] [next in thread]