[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bamarok=5D_src/core-impl/collections/db/sql=3A_Stupi?=
From:       Ralf Engels <ralf-engels () gmx ! de>
Date:       2011-02-27 11:04:25
Message-ID: 20110227110425.4EBFBA609B () git ! kde ! org
[Download RAW message or body]

Git commit e65186ff6cfdb0ff9f02723d178cbebfc32449b0 by Ralf Engels.
Committed on 27/02/2011 at 11:52.
Pushed by rengels into branch 'master'.

Stupid bug deleting tracks.
why didn't the auto tests catch that.

M  +3    -2    src/core-impl/collections/db/sql/SqlRegistry.cpp     

http://commits.kde.org/amarok/e65186ff6cfdb0ff9f02723d178cbebfc32449b0

diff --git a/src/core-impl/collections/db/sql/SqlRegistry.cpp \
b/src/core-impl/collections/db/sql/SqlRegistry.cpp index 8ba264b..7b9e90a 100644
--- a/src/core-impl/collections/db/sql/SqlRegistry.cpp
+++ b/src/core-impl/collections/db/sql/SqlRegistry.cpp
@@ -321,8 +321,9 @@ SqlRegistry::removeTrack( int urlId, const QString uid )
     // (deviceid,rpath is a unique key)
     // so we just write the uid into the path
     query = QString( "UPDATE urls SET deviceid=0, rpath='%1', directory=NULL "
-                     "WHERE id=%2;").arg( m_collection->sqlStorage()->escape(uid),
-                                          urlId );
+                     "WHERE id=%2;")
+        .arg( m_collection->sqlStorage()->escape(uid) )
+        .arg( urlId );
     m_collection->sqlStorage()->query( query );
     query = QString( "UPDATE statistics SET deleted=1 WHERE url=%1;").arg( urlId );
     m_collection->sqlStorage()->query( query );


[prev in list] [next in list] [prev in thread] [next in thread]