[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bchoqok=5D_plugins/videopreview=3A_checking_if_jobs_?=
From:       Mehrdad Momeny <mehrdad.momeny () gmail ! com>
Date:       2011-02-25 11:03:37
Message-ID: 20110225110337.3FC3CA60AE () git ! kde ! org
[Download RAW message or body]

Git commit 9e76071ed9560ef570f11a752e78508b28d6c330 by Mehrdad Momeny.
Committed on 21/02/2011 at 10:11.
Pushed by momeny into branch 'master'.

checking if jobs created right

M  +2    -10   plugins/videopreview/videopreview.cpp     

http://commits.kde.org/choqok/9e76071ed9560ef570f11a752e78508b28d6c330

diff --git a/plugins/videopreview/videopreview.cpp b/plugins/videopreview/videopreview.cpp
index 2326571..d639c2a 100644
--- a/plugins/videopreview/videopreview.cpp
+++ b/plugins/videopreview/videopreview.cpp
@@ -167,15 +167,10 @@ QString VideoPreview::parseYoutube(QString videoid, QPointer< Choqok::UI::PostWi
     KUrl th_url(youtubeUrl);
     KIO::TransferJob *job = KIO::get( th_url, KIO::NoReload, KIO::HideProgressInfo );
     QString title, description, thumb_url;
-//     QEventLoop loop;
-//     connect(job, SIGNAL(result(KJob*)), &loop, SLOT(quit()));
-//     job->start();
-//     loop.exec();
     QByteArray data;
 
-    if ( KIO::NetAccess::synchronousRun(job, Choqok::UI::Global::mainWindow(), &data) ) {
+    if ( job && KIO::NetAccess::synchronousRun(job, Choqok::UI::Global::mainWindow(), &data) ) {
         QDomDocument document;
-//         kDebug()<<job->data();
         document.setContent ( data );
         QDomElement root = document.documentElement();
         if ( !root.isNull() ) {
@@ -219,12 +214,9 @@ QString VideoPreview::parseVimeo(QString videoid, QPointer< Choqok::UI::PostWidg
     QEventLoop loop;
     KIO::TransferJob *job = KIO::get( th_url, KIO::NoReload, KIO::HideProgressInfo );
     QString title, description, thumb_url;
-//     connect(job, SIGNAL(result(KJob*)), &loop, SLOT(quit()));
-//     job->start();
-//     loop.exec();
     QByteArray data;
 
-    if ( KIO::NetAccess::synchronousRun(job, Choqok::UI::Global::mainWindow(), &data) ) {
+    if ( job && KIO::NetAccess::synchronousRun(job, Choqok::UI::Global::mainWindow(), &data) ) {
         QDomDocument document;
         document.setContent ( data );
         QDomElement root = document.documentElement();

[prev in list] [next in list] [prev in thread] [next in thread]