[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdesupport/emerge/bin/BuildSystem
From:       Wolfgang Rohdewald <wolfgang () rohdewald ! de>
Date:       2011-02-21 0:13:29
Message-ID: 20110221001329.590CFAC8BF () svn ! kde ! org
[Download RAW message or body]

SVN commit 1221902 by wrohdewald:

BuildSystemBase: remove abstract methods

those methods like configure() are redefined in derived
classes with conflicting signatures like configure()
in BinaryBuildSystem and QMakeBuildSystem(). This makes
it pointless to define a common ancestor.

By removing those methods, pylint will still raise
an exception if a derived class does not implement them,
and pylint is happier.


 M  +3 -21     BuildSystemBase.py  


--- trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py #1221901:1221902
@@ -43,29 +43,11 @@
             utils.die( "unknown %s compiler" % self.compiler() )
     makeProgramm = property(_getmakeProgram)
 
-    def configure(self):
-        """configure the target"""
-        utils.abstract()
-
-    def install(self):
-        """install the target into local install directory"""
-        utils.abstract()
-
-    def uninstall(self):
-        """uninstall the target from the local install directory"""
-        utils.abstract()
-
-    def runTests(self):
-        """run the test - if available - for the target"""
-        utils.abstract()
-
-    def make(self):
-        """make the target by runnning the related make tool"""
-        utils.abstract()
-
     def compile(self):
         """convencience method - runs configure() and make()"""
-        return self.configure() and self.make()
+        configure = getattr(self, 'configure')
+        make = getattr(self, 'make')
+        return configure() and make()
 
     def configureSourceDir(self):
         """returns source dir used for configure step"""
[prev in list] [next in list] [prev in thread] [next in thread]