[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bkde-baseapps=5D_dolphin/src/views=3A_Improve_perfor?=
From:       Peter Penz <peter.penz19 () gmail ! com>
Date:       2011-02-13 12:24:16
Message-ID: 20110213122416.A0335A609B () git ! kde ! org
[Download RAW message or body]

Git commit 680009b522b2c9eda03201ac02dc18994b5a8bd0 by Peter Penz.
Committed on 13/02/2011 at 13:19.
Pushed by ppenz into branch 'master'.

Improve performance when turning on the preview mode

If a change from a directory with disabled previews is done to a directory with \
enabled previews, also previews are generated for the previous directory as the \
preview-generator still contains the not updated directory lister. Because of this it \
is important to apply the view-properties after the directory-lister has been \
updated.

M  +10   -2    dolphin/src/views/dolphinview.cpp     

http://commits.kde.org/kde-baseapps/680009b522b2c9eda03201ac02dc18994b5a8bd0

diff --git a/dolphin/src/views/dolphinview.cpp b/dolphin/src/views/dolphinview.cpp
index 4ab16e0..db917ee 100644
--- a/dolphin/src/views/dolphinview.cpp
+++ b/dolphin/src/views/dolphinview.cpp
@@ -434,9 +434,13 @@ void DolphinView::refresh()
     m_active = true;
 
     createView();
-    applyViewProperties();
     reload();
 
+    // For performance reasons applying the view properties should be done after \
updating +    // the directory-lister URL with reload(). Otherwise in combination \
with enabled +    // previews the creation of already obsolete directory items gets \
triggered. +    applyViewProperties();
+
     setActive(oldActivationState);
     updateZoomLevel(oldZoomLevel);
 }
@@ -544,7 +548,6 @@ void DolphinView::setUrl(const KUrl& url)
 
     m_viewModeController->setUrl(url); // emits urlChanged, which we forward
     m_viewAccessor.prepareUrlChange(url);
-    applyViewProperties();
 
     // When changing the URL there is no need to keep the version
     // data of the previous URL.
@@ -554,6 +557,11 @@ void DolphinView::setUrl(const KUrl& url)
     connectViewAccessor();
     loadDirectory(url);
 
+    // For performance reasons applying the view properties should be done after \
updating +    // the directory-lister URL with loadDirectory(). Otherwise in \
combination with enabled +    // previews the creation of already obsolete directory \
items gets triggered. +    applyViewProperties();
+
     if (hadSelection || hasSelection()) {
         emitSelectionChangedSignal();
     }


[prev in list] [next in list] [prev in thread] [next in thread]