[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdesdk/scripts/kde-emacs
From:       Allen Winter <winter () kde ! org>
Date:       2011-02-08 20:50:20
Message-ID: 201102081550.21362.winter () kde ! org
[Download RAW message or body]

On Tuesday 08 February 2011 11:19:46 am David Faure wrote:
> On Tuesday 08 February 2011, Raphael Kubo da Costa wrote:
> > (CC'ing dfaure as he's the only other kde-emacs user I know ;)
> > 
> > Allen Winter <winter@kde.org> writes:
> > > SVN commit 1219435 by winterz:
> > > 
> > > Add Git support, direct from the official git contrib.
> > > 
> > >  A             git-blame.el
> > >  A             git.el
> > 
> > Is this really needed to be added to kde-emacs? If it's in git's
> > contrib/, why not let users add it themselves to their ~/.emacs if they
> > want to?
> 
> Well, to make it simple and working out of the box for everyone?
> xemacs is more useful if it has the useful stuff, than if everyone needs to 
> spend time finding out where's the stuff and how it works.
> 
> But the real reason imho is that this way we can add an extra layer on top 
> which makes things convenient -- e.g. I would love to see a function that 
> hides the git-status buffer step and just allows me to do git-diff-file-idiff (*) 
> for the current buffer. For such a function to exist, we need a dependency on 
> git.el, so we can't just say "those who want it, can install it".
> 
> (*) this is what made me drop again the idea of switching to another IDE :-)
> I've been using the equivalent ediff-based function for svn forever, and it's 
> just really convenient to be able to remove kDebug statements before 
> committing with only a few keystrokes. I know, git commit -p can do that too, 
> but I never understand the way it's asking me about it.
> 
> > Furthermore, git-blame.el does not say it is compatible with XEmacs, and
> > git.el says it _may_ be compatible with XEmacs.
> 
> Well, git.el is definitely working, at least git-status, git-diff and git-diff-
> file-idiff, which I tested.
> 

Granted we haven't tested all the features yet, but it does seem to work with XEmacs.

Interestingly, my distro does a package for these .el files for Emacs but not for XEmacs.

But I certainly understand Raphael's concerns.
We can always back out these files if they become problematic.

For now, I think this is a win.
[prev in list] [next in list] [prev in thread] [next in thread]