[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdenetwork/kopete/kopete
From:       Raphael Kubo da Costa <kubito () gmail ! com>
Date:       2011-02-05 5:27:55
Message-ID: 87lj1v9hk4.fsf () gmail ! com
[Download RAW message or body]

Lamarque Vieira Souza <lamarque@gmail.com> writes:

> Em Saturday 05 February 2011, Raphael Kubo da Costa escreveu:
>> Lamarque Souza <lamarque@gmail.com> writes:
>> > +bool compareOnlineStatus(const Kopete::Account *a, const Kopete::Account
>> > *b); +bool invertedCompareOnlineStatus(const Kopete::Account *a, const
>> > Kopete::Account *b);
>> 
>> Isn't it better to make them static?
>
> 	I do not know why. They are not declared in any header, nobody can use 
> them outside kopetewindow.cpp. Making them static would not improve anything 
> as far as I know. Anyway, I can do the change.

I admit I at first had C in my mind when I wrote about this -- if you
didn't add the static specifier, the functions would be accessible to
the other compilation units.

In this specific case, I can only think of the possibility of a name
clash if another compilation unit defines the same functions. Even
though it is unlikely, you may find it better to err on the safe side.
[prev in list] [next in list] [prev in thread] [next in thread]