[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bcalligra/words-layout=5Fperformance-sebsauer=5D_wor?=
From:       Sebastian Sauer <sebastian.sauer () kdab ! com>
Date:       2011-01-28 15:55:48
Message-ID: 20110128155548.449CBA6094 () git ! kde ! org
[Download RAW message or body]

Git commit f9bb9d5ea48f3475b0a6aff692b964cea0c6c2c9 by Sebastian Sauer.
Pushed by sebsauer into branch 'words-layout_performance-sebsauer'.

remove that commented out code-path again which didn't bring any performance-boost \
anyways.

M  +2    -17   words/part/KWDocument.cpp     

http://commits.kde.org/47e7010d/f9bb9d5ea48f3475b0a6aff692b964cea0c6c2c9

diff --git a/words/part/KWDocument.cpp b/words/part/KWDocument.cpp
index 0bb380c..a5a8218 100644
--- a/words/part/KWDocument.cpp
+++ b/words/part/KWDocument.cpp
@@ -819,29 +819,14 @@ void KWDocument::requestMoreSpace(KWTextFrameSet *fs)
             afterPageNum = last.pageNumber();
 
         kDebug() << "frameSet=" << fs << "pageDiff=" << pageDiff << "pageCount=" << \
m_pageManager.pageCount() << "pageNumber=" << page.pageNumber() << "afterPageNum=" << \
                afterPageNum;
-#if 1
+
         KWPageInsertCommand cmd(this, afterPageNum, masterPageName);
-        cmd.redo();
+        cmd.redo(); // does also schedule an update using the PageProcessingQueue
         KWPage newPage = cmd.page();
         Q_ASSERT(newPage.isValid());
         newPage.setAutoGenerated(true);
         if (m_magicCurtain)
             m_magicCurtain->revealFramesForPage(newPage.pageNumber(), \
                newPage.offsetInDocument());
-#else
-        KWPage prevPage = pageManager()->page(afterPageNum);
-        KWPageStyle pageStyle = pageManager()->pageStyle(masterPageName);
-        KWPage newPage = pageManager()->insertPage(afterPageNum, pageStyle);
-        Q_ASSERT(newPage.isValid());
-        newPage.setAutoGenerated(true);
-
-        // make sure we have updated the view before we do anything else
-        firePageSetupChanged();
-
-        if (m_magicCurtain)
-            m_magicCurtain->revealFramesForPage(newPage.pageNumber(), \
                newPage.offsetInDocument());
-
-        pageQueue()->addPage(newPage);
-#endif
     }
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]