[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/extragear/graphics/digikam/core
From:       Marcel Wiesweg <marcel.wiesweg () gmx ! de>
Date:       2011-01-27 18:42:58
Message-ID: 20110127184258.86814AC8BA () svn ! kde ! org
[Download RAW message or body]

SVN commit 1217517 by mwiesweg:

No need to emit curvesChanged signal from mouseReleased.
It's sufficient to release it from mousePress and mouseMove.

Use update() instead of repaint().

BUG: 246772


 M  +4 -1      NEWS  
 M  +12 -14    libs/dimg/filters/curves/curveswidget.cpp  


--- branches/extragear/graphics/digikam/core/NEWS #1217516:1217517
@@ -48,4 +48,7 @@
 031 ==> 229471 : Editor: forward when saving in progress.
 032 ==> 255858 : Memory leak (?) while thumbnailing very large files!
 033 ==> 264363 : Image editor always crashes when triggering Colour Auto-Correction.
-034 ==> 
+034 ==> 243066 : Timeline view does not display images.
+035 ==> 243069 : Video replay restarts when starring.
+036 ==> 246772 : Curves: Don't recalculate on mouseUp if the position of the marker did not change.
+037 ==> 
--- branches/extragear/graphics/digikam/core/libs/dimg/filters/curves/curveswidget.cpp #1217516:1217517
@@ -492,7 +492,7 @@
 {
     d->grabPoint    = -1;
     d->guideVisible = false;
-    repaint();
+    update();
 }
 
 ImageCurves* CurvesWidget::curves() const
@@ -516,7 +516,7 @@
     d->clearFlag     = CurvesWidgetPriv::HistogramFailed;
     d->progressCount = 0;
     d->progressTimer->stop();
-    repaint();
+    update();
     setCursor(Qt::ArrowCursor);
 }
 
@@ -524,7 +524,7 @@
 {
     d->guideVisible = true;
     d->colorGuide   = color;
-    repaint();
+    update();
 }
 
 void CurvesWidget::curveTypeChanged()
@@ -549,7 +549,7 @@
             break;
     }
 
-    repaint();
+    update();
     emit signalCurvesChanged();
 }
 
@@ -558,7 +558,7 @@
     setCursor(Qt::WaitCursor);
     d->clearFlag = CurvesWidgetPriv::HistogramStarted;
     d->progressTimer->start(200);
-    repaint();
+    update();
 }
 
 void CurvesWidget::slotCalculationFinished(const ImageHistogram*, bool success)
@@ -568,14 +568,14 @@
         // Repaint histogram
         d->clearFlag = CurvesWidgetPriv::HistogramCompleted;
         d->progressTimer->stop();
-        repaint();
+        update();
         setCursor(Qt::ArrowCursor);
     }
     else
     {
         d->clearFlag = CurvesWidgetPriv::HistogramFailed;
         d->progressTimer->stop();
-        repaint();
+        update();
         setCursor(Qt::ArrowCursor);
         emit signalHistogramComputationFailed();
     }
@@ -594,7 +594,7 @@
 
 void CurvesWidget::slotProgressTimerDone()
 {
-    repaint();
+    update();
     d->progressTimer->start(200);
 }
 
@@ -712,7 +712,8 @@
     }
 
     d->curves->curvesCalculateCurve(d->channelType);
-    repaint();
+    emit signalCurvesChanged();
+    update();
 }
 
 void CurvesWidget::mouseReleaseEvent(QMouseEvent* e)
@@ -729,9 +730,6 @@
 
     setCursor(Qt::ArrowCursor);
     d->grabPoint = -1;
-    d->curves->curvesCalculateCurve(d->channelType);
-    repaint();
-    emit signalCurvesChanged();
 }
 
 void CurvesWidget::mouseMoveEvent(QMouseEvent* e)
@@ -835,7 +833,7 @@
     d->xMouseOver = x;
     d->yMouseOver = d->imageHistogram->getMaxSegmentIndex() - y;
     emit signalMouseMoved(d->xMouseOver, d->yMouseOver);
-    repaint();
+    update();
 }
 
 void CurvesWidget::leaveEvent(QEvent*)
@@ -843,7 +841,7 @@
     d->xMouseOver = -1;
     d->yMouseOver = -1;
     emit signalMouseMoved(d->xMouseOver, d->yMouseOver);
-    repaint();
+    update();
 }
 
 void CurvesWidget::setChannelType(ChannelType channel)
[prev in list] [next in list] [prev in thread] [next in thread]