[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/nepomuk/core
From:       Vishesh Handa <handa.vish () gmail ! com>
Date:       2011-01-24 5:06:44
Message-ID: 20110124050644.2AD7AAC8B9 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1216578 by vhanda:

Optimization in  ResourceFilterModel::updateProperty - Avoid calling toSet() multiple \
times


 M  +4 -3      resourcefiltermodel.cpp  


--- trunk/KDE/kdelibs/nepomuk/core/resourcefiltermodel.cpp #1216577:1216578
@@ -132,16 +132,17 @@
         return removeProperty( resource, property );
     }
 
-    QList<Node> existingValues = listStatements( Statement( resource, property, \
Node() ) ).iterateObjects().allNodes(); +    QSet<Node> existingValuesSet = \
listStatements( Statement( resource, property, Node() ) \
).iterateObjects().allNodes().toSet(); +    QSet<Node> valuesSet = values.toSet();
 
     Error::ErrorCode c = Error::ErrorNone;
-    foreach( const Node &node, existingValues.toSet() - values.toSet() ) {
+    foreach( const Node &node, existingValuesSet - valuesSet ) {
         if ( ( c = removeAllStatements( Statement( resource, property, node ) ) ) != \
Error::ErrorNone ) {  return c;
         }
     }
 
-    QSet<Node> newNodes = values.toSet() - existingValues.toSet();
+    QSet<Node> newNodes = valuesSet- existingValuesSet;
     if ( !newNodes.isEmpty() ) {
         QUrl context = mainContext();
         foreach( const Node &node, newNodes ) {


[prev in list] [next in list] [prev in thread] [next in thread]