[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/css
From:       Maks Orlovich <maksim () kde ! org>
Date:       2011-01-18 23:32:40
Message-ID: 20110118233240.3491CAC8B7 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1215524 by orlovich:


Make sure we honor width: set on a button with display: inline. 
This is done by mutating it into inline-block (WebCore does that,
but a lot more other stuff, too, which doesn't make sense here given 
our native-widgets approach).

Fixes the star (so that's what the weird fancy character was) and loupe 
icons on google search results getting cutoff.



 M  +7 -0      cssstyleselector.cpp  


--- trunk/KDE/kdelibs/khtml/css/cssstyleselector.cpp #1215523:1215524
@@ -899,6 +899,13 @@
             }
             else
                 style->setDisplay(BLOCK);
+        } else if (e && e->id() == ID_BUTTON && style->isOriginalDisplayInlineType()) {
+            // <button>s are supposed to be replaced elements; but we don't handle 
+            // them as such (as they are rendered as CSS contexts, not natives 
+            // with intrinsic sizes), so we must be careful not to make them fully 
+            // inline, as that will display stuff like width:; so mutate inline-like
+            // display types into inline-block
+            style->setDisplay(INLINE_BLOCK);
         }
 
         // After performing the display mutation, check our position.  We do not honor position:relative on
[prev in list] [next in list] [prev in thread] [next in thread]