[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps/dolphin/src
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2011-01-17 14:26:45
Message-ID: AANLkTikVk8pumCsRJr6D7hyBS-aqFBdNyt2is32Wqc3d () mail ! gmail ! com
[Download RAW message or body]

Hi,

2011/1/16 Sebastian Doerner <sebastian@sebastian-doerner.de>:
> SVN commit 1214916 by doerner:
>
> Simplify DolphinMainWindow::replaceLocation()
>
>  M  +1 -3      dolphinmainwindow.cpp
>
>
> --- trunk/KDE/kdebase/apps/dolphin/src/dolphinmainwindow.cpp #1214915:1214916
> @@ -844,12 +844,10 @@
>  {
>     KUrlNavigator* navigator = m_activeViewContainer->urlNavigator();
>     navigator->setUrlEditable(true);
> -    navigator->setFocus();
>
>     // select the whole text of the combo box editor
>     QLineEdit* lineEdit = navigator->editor()->lineEdit();  // krazy:exclude=qclasses
> -    const QString text = lineEdit->text();
> -    lineEdit->setSelection(0, text.length());
> +    lineEdit->selectAll();
>  }

while the second part of the "simplification" is certainly nice,
removing "navigator->setFocus();" looks like a bug to me. A user who
selects the location bar text will probably want to enter a new URL
using the keyboard, so focusing the navigator makes a lot of sense
IMHO. Have you discussed this change with Peter?

Cheers,
Frank

[prev in list] [next in list] [prev in thread] [next in thread]