[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/graphics/kipi-plugins
From:       Laurent Montel <montel () kde ! org>
Date:       2011-01-14 8:44:53
Message-ID: 20110114084453.DF326AC8B3 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1214343 by mlaurent:

Don't check pointer before delete it


 M  +0 -2      expoblending/blendingdlg/enfusestack.cpp  
 M  +0 -4      expoblending/manager/manager.cpp  
 M  +0 -1      printimages/tphoto.cpp  
 M  +0 -6      removeredeyes/removeredeyeswindow.cpp  
 M  +0 -3      removeredeyes/workerthread.cpp  


--- trunk/extragear/graphics/kipi-plugins/expoblending/blendingdlg/enfusestack.cpp #1214342:1214343
@@ -225,7 +225,6 @@
 void EnfuseStackList::slotRemoveItem()
 {
     EnfuseStackItem* item = dynamic_cast<EnfuseStackItem*>(currentItem());
-    if (item)
         delete item;
 }
 
@@ -275,7 +274,6 @@
 void EnfuseStackList::removeItem(const KUrl& url)
 {
     EnfuseStackItem* item = findItemByUrl(url);
-    if (item)
         delete item;
 }
 
--- trunk/extragear/graphics/kipi-plugins/expoblending/manager/manager.cpp #1214342:1214343
@@ -85,11 +85,7 @@
 {
     delete d->about;
     delete d->thread;
-
-    if (d->wizard)
         delete d->wizard;
-
-    if (d->dlg)
         delete d->dlg;
 
     delete d;
--- trunk/extragear/graphics/kipi-plugins/printimages/tphoto.cpp #1214342:1214343
@@ -107,7 +107,6 @@
     painter.drawImage(0, 0, image );
     painter.end();
 
-    if (m_size)
         delete m_size;
     m_size = new QSize(photo.width(), photo.height());
 }
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/removeredeyeswindow.cpp #1214342:1214343
@@ -414,10 +414,7 @@
     d->settings.unprocessedMode = d->unprocessedSettingsBox->handleMode();
 
     // reset save method
-    if (d->saveMethod)
-    {
         delete d->saveMethod;
-    }
 
     d->saveMethod = SaveMethodFactory::create(d->settings.storageMode);
 }
@@ -823,10 +820,7 @@
 
 void RemoveRedEyesWindow::unloadLocator()
 {
-    if (d->locator)
-    {
         delete d->locator;
-    }
 
     if (d->locatorSettingsWidget)
     {
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/workerthread.cpp #1214342:1214343
@@ -87,10 +87,7 @@
     // wait for the thread to finish
     wait();
 
-    if (d->saveMethod)
-    {
         delete d->saveMethod;
-    }
 
     delete d;
 }
[prev in list] [next in list] [prev in thread] [next in thread]