[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/plasma/private
From:       Marco Martin <notmart () gmail ! com>
Date:       2011-01-06 21:43:51
Message-ID: 20110106214351.97F97AC8B0 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1212407 by mart:

close the strage db when the job is over.
there were dangling file pointers before that could crash plasma when they go beyond \
the maximum allowed limit BUG:259833
CCBUG:247798
BUG:235051



 M  +3 -4      storage.cpp  


--- trunk/KDE/kdelibs/plasma/private/storage.cpp #1212406:1212407
@@ -85,7 +85,6 @@
       query.bindValue(":datavalue", params["data"]);
       const bool success = query.exec();
       setResult(success);
-      return;
 
     } else if (operationName() == "retrieve") {
         QSqlQuery query(m_db);
@@ -124,9 +123,6 @@
             }
 
             setResult(h);
-            return;
-        } else {
-            return;
         }
 
     } else if (operationName() == "delete") {
@@ -165,6 +161,9 @@
     } else {
         setError(true);
     }
+    //TODO: use a single shared db per thread
+    m_db.close();
+    QSqlDatabase::removeDatabase(m_db.connectionName());
 }
 
 Plasma::ServiceJob* Storage::createJob(const QString &operation, QMap<QString, \
QVariant> &parameters)


[prev in list] [next in list] [prev in thread] [next in thread]