[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdepim] 4cb6e7c: Crash when unsubscribing from a newsgroup
From:       Olivier Trichet <nive () nivalis ! org>
Date:       2011-01-02 18:13:28
Message-ID: 20110102181328.58B4CA6090 () git ! kde ! org
[Download RAW message or body]

commit 4cb6e7c84920e7bec3813a431fd086eeed447f05
branch master
Author: Olivier Trichet <nive@nivalis.org>
Date:   Sun Jan 2 18:50:02 2011 +0100

    Crash when unsubscribing from a newsgroup
    
    The event loop was reentered and the KNCollectionViewItem being deleted
    was reaccessed to update the display.
    Worked around: hide the item before deleting it.
    
    BUG: 248256

diff --git a/knode/kncollectionview.cpp b/knode/kncollectionview.cpp
index 42cc70b..9bf1676 100644
--- a/knode/kncollectionview.cpp
+++ b/knode/kncollectionview.cpp
@@ -171,6 +171,7 @@ void KNCollectionView::removeGroup( KNGroup::Ptr g )
   if (!g->listItem())
     return;
 
+  g->listItem()->setHidden( true ); // work around bug 248256
   delete g->listItem();
   g->setListItem(0);
 }
[prev in list] [next in list] [prev in thread] [next in thread]