[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepimlibs
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2010-12-30 11:11:23
Message-ID: 20101230111123.2AD67AC8AC () svn ! kde ! org
[Download RAW message or body]

SVN commit 1210270 by aacid:

const & in foreach
do not use values in foreach


 M  +1 -1      akonadi/resourcebase.cpp  
 M  +1 -1      kholidays/parsers/plan2/holidayparserdriverplan.cpp  


--- trunk/KDE/kdepimlibs/akonadi/resourcebase.cpp #1210269:1210270
@@ -890,7 +890,7 @@
   Q_Q( ResourceBase );
   emit q->percent( mUnemittedProgress );
 
-  Q_FOREACH( QVariantMap statusMap, mUnemittedAdvancedStatus.values() ) {
+  Q_FOREACH( const QVariantMap &statusMap, mUnemittedAdvancedStatus ) {
       emit q->advancedStatus( statusMap );
   }
   mUnemittedProgress = 0;
--- trunk/KDE/kdepimlibs/kholidays/parsers/plan2/holidayparserdriverplan.cpp \
#1210269:1210270 @@ -91,7 +91,7 @@
 void HolidayParserDriverPlan::parse()
 {
     // Parse the file using every calendar system in the file
-    foreach( QString calendar, m_fileCalendarTypes ) {
+    foreach( const QString &calendar, m_fileCalendarTypes ) {
 
         // Cater for events defined in other Calendar Systems where request year \
                could cover 2 or 3 event years
         // Perhaps also parse year before and year after to allow events to span \
years or shift to other year?


[prev in list] [next in list] [prev in thread] [next in thread]