[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/kwin
From:       Thomas Lübking <thomas.luebking () gmail ! com>
Date:       2010-12-19 21:32:02
Message-ID: 20101219213202.E7878AC8AA () svn ! kde ! org
[Download RAW message or body]

SVN commit 1207826 by luebking:

exclude non opaque (NOT "non ARGB") windows from lanczos filter unless we've a \
                working blendfunction for the cached texture
BUG: 258439


 M  +2 -3      lanczosfilter.cpp  


--- trunk/KDE/kdebase/workspace/kwin/lanczosfilter.cpp #1207825:1207826
@@ -170,7 +170,7 @@
 void LanczosFilter::performPaint( EffectWindowImpl* w, int mask, QRegion region, \
WindowPaintData& data )  {
 #ifdef KWIN_HAVE_OPENGL_COMPOSITING
-    if( effects->compositingType() == KWin::OpenGLCompositing &&
+    if( effects->compositingType() == KWin::OpenGLCompositing && data.opacity == 1.0 \
                &&
         KGlobalSettings::graphicEffectsLevel() & \
KGlobalSettings::SimpleAnimationEffects )  {
         if (!m_inited)
@@ -216,7 +216,6 @@
                 if( cachedTexture->width() == tw && cachedTexture->height() == th )
                     {
                     cachedTexture->bind();
-                    data.opacity *= 0.99;
                     prepareRenderStates( cachedTexture, data.opacity, \
data.brightness, data.saturation );  cachedTexture->render( textureRect, textureRect \
                );
                     restoreRenderStates( cachedTexture, data.opacity, \
data.brightness, data.saturation ); @@ -361,7 +360,7 @@
 void LanczosFilter::prepareRenderStates( GLTexture* tex, double opacity, double \
brightness, double saturation )  {
 #ifdef KWIN_HAVE_OPENGL_COMPOSITING
-    const bool alpha = false; // true; WORKAROUND - "true" causes issues with at \
least nvidia chips and translucent windows "overbrightning" +    const bool alpha = \
true;  // setup blending of transparent windows
     glPushAttrib( GL_ENABLE_BIT );
     glEnable( GL_BLEND );


[prev in list] [next in list] [prev in thread] [next in thread]