[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/kmenuedit
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2010-12-17 22:50:54
Message-ID: 20101217225054.49E0BAC8A8 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1207417 by aseigo:

one of the benefits of plasma getting bug reports for _everything_ is i end up seeing \
things that bug me while triaging them ... e.g. the config dialog of kmenuedit. so:

* Misc -> General (i18n'd elsewhere in kmenuedit already, so no string breakage)
* give it an icon
* move it above spell check config as per most KDE apps
* add a spacer to the bottom of the layout so the UI is at the top, not floating in \
                the middle vertically
* get rid of the superfluous groupbox


 M  +12 -13    preferencesdlg.cpp  


--- trunk/KDE/kdebase/workspace/kmenuedit/preferencesdlg.cpp #1207416:1207417
@@ -32,16 +32,17 @@
     setButtons( Ok | Cancel );
     setDefaultButton( Ok );
 
+    m_pageMisc = new MiscPage( this );
+    KPageWidgetItem *page = new KPageWidgetItem( m_pageMisc , i18n( "General" ) );
+    page->setIcon( KIcon( "kmenuedit" ) );
+    addPage(page);
+
     m_pageSpellChecking = new SpellCheckingPage( this );
-    KPageWidgetItem *page = new KPageWidgetItem( m_pageSpellChecking , i18n( "Spell \
Checking" ) ); +    page = new KPageWidgetItem( m_pageSpellChecking , i18n( "Spell \
Checking" ) );  page->setHeader( i18n( "Spell checking Options" ) );
     page->setIcon( KIcon( "tools-check-spelling" ) );
     addPage(page);
 
-    m_pageMisc = new MiscPage( this );
-    page = new KPageWidgetItem( m_pageMisc , i18n( "Misc" ) );
-    addPage(page);
-
     connect( this, SIGNAL( okClicked() ), this, SLOT( slotSave() ) );
 }
 
@@ -68,16 +69,14 @@
 MiscPage::MiscPage( QWidget *parent )
     : QWidget( parent )
 {
-    QHBoxLayout *lay = new QHBoxLayout( this );
-    QGroupBox *group = new QGroupBox(i18n( "General" ) ) ;
-    lay->addWidget( group );
-    QVBoxLayout *vbox = new QVBoxLayout;
-    m_showHiddenEntries = new QCheckBox( i18n( "Show hidden entries" ) );
-    vbox->addWidget( m_showHiddenEntries );
-    group->setLayout( vbox );
+    QVBoxLayout *lay = new QVBoxLayout( this );
+    m_showHiddenEntries = new QCheckBox( i18n( "Show hidden entries" ), this );
+    lay->addWidget( m_showHiddenEntries );
+    lay->addStretch();
+    setLayout( lay );
+
     KConfigGroup grp( KGlobal::config(), "General" );
     m_showHiddenEntries->setChecked(  grp.readEntry( "ShowHidden", false ) );
-    setLayout( lay );
 }
 
 void MiscPage::saveOptions()


[prev in list] [next in list] [prev in thread] [next in thread]