[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/sysadmin/libqapt/src
From:       Jonathan Michael Thomas <echidnaman () kubuntu ! org>
Date:       2010-12-16 15:49:36
Message-ID: 20101216154936.CF53CAC8A8 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1207021 by jmthomas:

Since package names are always latin1-compliant, prevent the unnecessary conversion \
of const char * -> std::string -> QString::fromAscii -> QString::fromLatin1 by using \
QLatin1String to wrap around the const char *, making the conversion process look \
more like const char * -> QL1S -> QString::fromLatin1


 M  +4 -4      package.cpp  


--- trunk/extragear/sysadmin/libqapt/src/package.cpp #1207020:1207021
@@ -733,7 +733,7 @@
     QStringList reverseDependsList;
 
     for(pkgCache::DepIterator it = d->packageIter->RevDependsList(); !it.end(); \
                ++it) {
-        reverseDependsList << QString::fromStdString(it.ParentPkg().Name());
+        reverseDependsList << QLatin1String(it.ParentPkg().Name());
     }
 
     return reverseDependsList;
@@ -775,7 +775,7 @@
         }
         pkgDepCache::StateCache &rState = (*d->depCache)[pkg];
         if (it->Type == pkgCache::Dep::Recommends && (rState.CandidateVer != 0 )) {
-            recommends << QString::fromStdString(it.TargetPkg().Name());
+            recommends << QLatin1String(it.TargetPkg().Name());
         }
     }
 
@@ -801,7 +801,7 @@
         }
         pkgDepCache::StateCache &sState = (*d->depCache)[pkg];
         if (it->Type == pkgCache::Dep::Suggests && (sState.CandidateVer != 0 )) {
-            suggests << QString::fromStdString(it.TargetPkg().Name());
+            suggests << QLatin1String(it.TargetPkg().Name());
         }
     }
 
@@ -827,7 +827,7 @@
         }
         pkgDepCache::StateCache &eState = (*d->depCache)[pkg];
         if (it->Type == pkgCache::Dep::Enhances && (eState.CandidateVer != 0 )) {
-            enhances << QString::fromStdString(it.TargetPkg().Name());
+            enhances << QLatin1String(it.TargetPkg().Name());
         }
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]