[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [KDevelop-Custom-BuildSystem] 5cc4569: Fix an if()/endif()
From:       Christophe Giboudeaux <cgiboudeaux () gmail ! com>
Date:       2010-12-10 20:57:38
Message-ID: 4D029442.7040707 () gmail ! com
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 10/12/2010 21:41, Andreas Pakulat a écrit :
> On 10.12.10 20:47:38, Christophe Giboudeaux wrote:
> > commit 5cc4569c8514937aedf51e5dd33928d6e138cae7
> > branch master
> > Author: Christophe Giboudeaux <cgiboudeaux@gmail.com>
> > Date:   Fri Dec 10 20:48:15 2010 +0100
> > 
> > Fix an if()/endif() warning.
> 
> This is wrong, please read up on the cmake documentation. The correct
> fix is to replicate the complete if() part as long as KDE still depends
> on cmake 2.6.
> 

Hm.. you mean this ?

http://www.cmake.org/Wiki/CMake_FAQ#Isn.27t_the_.22Expression.22_in_the_.22ELSE_.28Expression.29.22_confusing.3F


« As of CMake 2.6.0 the ELSE() and ENDIF() constructs can be empty. The
same is true for closing constructs on ENDMACRO(), ENDFUNCTION(), and
ENDFOREACH() »

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk0ClEIACgkQxN4yrBrjqDNi9gCgp4VD98R0EHBTEo+LDkbxRx5J
JfIAniF0TU59gDRxLJ9yQrD6YLaW0Udh
=0UTq
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]