[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui/itemviews
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2010-12-10 13:26:33
Message-ID: 20101210132633.C04C1AC8A6 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1205215 by freininghaus:

In KCategorizedView::updateGeometries(), restore the vertical offset
not only in ScrollPerPixel, but also in ScrollPerItem mode. Fixes the
problem that Dolphin's Icons view may scroll to the top unexpectedly.

CCBUG: 256042


 M  +2 -3      kcategorizedview.cpp  


--- trunk/KDE/kdelibs/kdeui/itemviews/kcategorizedview.cpp #1205214:1205215
@@ -1365,11 +1365,10 @@
         verticalScrollBar()->setSingleStep(lastItemRect.height());
         const int rowsPerPage = qMax(viewport()->height() / lastItemRect.height(), 1);
         verticalScrollBar()->setPageStep(rowsPerPage * lastItemRect.height());
+    }
+
         verticalScrollBar()->setRange(0, bottomRange);
-    } else {
-        verticalScrollBar()->setRange(0, bottomRange);
         verticalScrollBar()->setValue(oldVerticalOffset);
-    }
 
     //TODO: also consider working with the horizontal scroll bar. since at this level I am not still
     //      supporting "top to bottom" flow, there is no real problem. If I support that someday
[prev in list] [next in list] [prev in thread] [next in thread]