[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/komo/kdelibs/sonnet/plugins
From:       David Faure <faure () kde ! org>
Date:       2010-12-08 13:46:52
Message-ID: 201012081446.53011.faure () kde ! org
[Download RAW message or body]

On Tuesday 07 December 2010, Andre Heinecke wrote:
> Hi,
> I apologize about the quality of this commit.
> 
> As you might have seen this was just a global search and replace on the
> Sonnet Code, i needed this commit to be in there for the night and had no
> time to clean it up.
> 
> I will do so asap.

OK, this looks better, but I still wonder why it's necessary.

--- sonnet/plugins/aspell/kspell_aspellclient.h (revision 1204326)
+++ sonnet/plugins/aspell/kspell_aspellclient.h (revision 1204417)
@@ -31,7 +31,7 @@ namespace Sonnet {
 }
 using Sonnet::SpellerPlugin;
 
-class ASpellClient : public Sonnet::Client
+class ASpellClient : public Sonnet::SonnetClient
 {
     Q_OBJECT
 public:
[...]

The classname is already namespaced in "Sonnet", where does the clash come 
from?
From some "using namespace Sonnet;" somewhere? But then I don't see the 
relation with building static.

Sorry for being noisy; I'm just wondering about the fact that, well, probably 
all the changes necessary for WinCE will end up in trunk kdelibs one day?

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

[prev in list] [next in list] [prev in thread] [next in thread]