On Friday 03 December 2010 15:48:43 David Faure wrote: > On Thursday 02 December 2010, Peter Penz wrote: > > SVN commit 1202948 by ppenz: > > > > Fix issue that previews are not shown in the trash. The root cause is > > that KUrl::isLocalFile() for the trash returns false (which is correct > > corresponding to the documentation of isLocalFile()) and hence the > > maximum size for remote files is used (which is 0 per default). From a > > users point of view the trash should be considered as "local" and hence > > the maximum size for local files should be considered for previews. > > BUG: 257928 > > Yep, makes sense. > > However there are more protocols than trash:/, which are "local files > viewed differenty", and in fact there's a generic way of testing for this: > KProtocolInfo::protocolClass. > > This would become: > > if (itemUrl.isLocalFile() || > KProtocolInfo::protocolClass(itemUrl.protocol()) == ":local") Ah, good to know :-) I've just committed an update, thanks for checking!