[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kio/kio
From:       Peter Penz <peter.penz19 () gmail ! com>
Date:       2010-12-02 20:55:18
Message-ID: 20101202205518.422F2AC8A4 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1202948 by ppenz:

Fix issue that previews are not shown in the trash. The root cause is that \
KUrl::isLocalFile() for the trash returns false (which is correct corresponding to \
the documentation of isLocalFile()) and hence the maximum size for remote files is \
used (which is 0 per default). From a users point of view the trash should be \
considered as "local" and hence the maximum size for local files should be considered \
for previews.

BUG: 257928
FIXED-IN: 4.6.0


 M  +2 -1      previewjob.cpp  


--- trunk/KDE/kdelibs/kio/kio/previewjob.cpp #1202947:1202948
@@ -352,7 +352,8 @@
 
             bool skipCurrentItem = false;
             const KIO::filesize_t size = (KIO::filesize_t)entry.numberValue( \
                KIO::UDSEntry::UDS_SIZE, 0 );
-            if (d->currentItem.item.mostLocalUrl().isLocalFile())
+            const KUrl itemUrl = d->currentItem.item.mostLocalUrl();
+            if (itemUrl.isLocalFile() || itemUrl.protocol() == \
QLatin1String("trash"))  {
                 skipCurrentItem = !d->ignoreMaximumSize && size > \
                d->maximumLocalSize
                                   && \
!d->currentItem.plugin->property("IgnoreMaximumSize").toBool();


[prev in list] [next in list] [prev in thread] [next in thread]