[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [Amarok] c4a68d1: Prevent collection scanner zombies
From:       "Rick W. Chen" <stuffcorpse () archlinux ! us>
Date:       2010-12-01 9:57:11
Message-ID: 20101201095711.GD3225 () axa ! home ! nz
[Download RAW message or body]

On 01 Dec 2010 00:55 +0100, Ralf Engels:
> commit c4a68d140c6ba8b31e8e241b38719684d796df27
> branch master
> Author: Ralf Engels <ralf-engels@gmx.de>
> Date:   Wed Dec 1 00:54:33 2010 +0100
> 
> Prevent collection scanner zombies
> 
> diff --git a/src/core-impl/collections/db/ScanManager.cpp \
> b/src/core-impl/collections/db/ScanManager.cpp index 098eccb..817de3b 100644
> --- a/src/core-impl/collections/db/ScanManager.cpp
> +++ b/src/core-impl/collections/db/ScanManager.cpp
> @@ -313,7 +313,7 @@ ScannerJob::~ScannerJob()
> {
> disconnect( m_scanner, 0, this, 0 );
> m_scanner->terminate();
> -        m_scanner->deleteLater();
> +        delete m_scanner;
> m_scanner = 0;
> }

This is causing the scanner to crash at the end of scanning.
http://pastebin.ca/2007545

-- 
    Rick


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic