[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/mobile
From:       Artur Duque de Souza <asouza () kde ! org>
Date:       2010-12-01 0:31:40
Message-ID: 20101201003140.80CB5AC8A3 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1202469 by asouza:

Use the whole screen while displaying attachments

The 'Flap' widget does not properly support changing on demand the
width of it's content. Because of this, it was very hard to make it
grow after the selection of a model without modifying the 'Flap' code.

To avoid regressions, I'm postponing the fix of the 'Flap' (that is used
in too many places to be changed now - for komo3) and using the default
width to display the attachments. This solves the issue of not properly
displaying the attachments, besides not being the most beautiful way of
doing it.

Before closing this bug, we'll do some polishing on the UI.

CCBUG: 256758


 M  +0 -4      lib/AttachmentList.qml  
 M  +0 -8      mail/kmail-mobile.qml  


--- trunk/KDE/kdepim/mobile/lib/AttachmentList.qml #1202468:1202469
@@ -31,8 +31,6 @@
   property int rowHeight: 48
   property int attachmentListWidth: 300
   property int actionListWidth: 240
-  property int requestedWidth: attachmentListWidth
-  property bool requestWidth: true
 
   /** Emittted when an attachment has been selected. */
   signal openAttachment(string url, string mimeType)
@@ -178,14 +176,12 @@
       name: "actionState"
       when: (attachmentListView.currentIndex >= 0 && attachmentListView.currentIndex \
< model.attachmentCount) && attachmentListView.currentMimeType.indexOf( "image" ) != \
                0
       PropertyChanges { target: actionView; width: actionListWidth; visible: true }
-      PropertyChanges { target: _attachmentList; requestedWidth: attachmentListWidth \
+ actionListWidth }  },
 
     State {
       name: "previewState"
       when: (attachmentListView.currentIndex >= 0 && attachmentListView.currentIndex \
< model.attachmentCount) && attachmentListView.currentMimeType.indexOf( "image" ) == \
0  PropertyChanges { target: previewView; visible: true }
-      PropertyChanges { target: _attachmentList; requestWidth: false; }
     }
   ]
 
--- trunk/KDE/kdepim/mobile/mail/kmail-mobile.qml #1202468:1202469
@@ -490,16 +490,8 @@
           }
         }
       ]
-
-      states: [
-        QML.State {
-          name: "useRequestedWidth"
-          when: attachmentView.requestWidth
-          QML.PropertyChanges { target: attachmentPanel; contentWidth: \
attachmentView.requestedWidth; }  }
-      ]
     }
-  }
 
   QML.Loader {
     anchors.fill: parent


[prev in list] [next in list] [prev in thread] [next in thread]