[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/devtools
From:       Raphael Kubo da Costa <kubito () gmail ! com>
Date:       2010-11-17 19:46:14
Message-ID: 20101117194614.17CC3AC8A0 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1198185 by rkcosta:

Remove cmake/modules/ and cmake/CMakeLists.txt

cmake/modules only had yet another copy of FindIcecream.cmake, and
besides that the file was being installed, which is not good
(Find*.cmake files should not be installed by the applications
themselves).

Furthermore, CMAKE_MODULE_PATH is not being set in the top-level
CMakeLists.txt file anymore. As discussed today on #kde-devel, doing
so meant that we considered the applications in playground part of a
coherent bundle of apps, such as kdenetwork or kdesdk. This is not the
case, as each application is here only because they are still under
heavy development; the situation is more similar to extragear, in
which each application does its own release separately.



 M  +0 -9      CMakeLists.txt  
 D             cmake/CMakeLists.txt  
 D             cmake/modules (directory)  


--- trunk/playground/devtools/CMakeLists.txt #1198184:1198185
@@ -1,28 +1,19 @@
 project(playground-devtools)
 
-set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules \
                )
-
 find_package(KDE4 REQUIRED)
 include (KDE4Defaults)
 include(MacroOptionalAddSubdirectory)
 include(MacroOptionalDependPackage)
 
-macro_optional_find_package(Icecream)
-
-macro_log_feature(LIBICECREAM_FOUND "libicecream" "Icecream distributed compilation \
                lib, needed for icemon" "http://en.opensuse.org/Icecream")
-
 macro_optional_find_package(KDevPlatform)
 
 macro_log_feature(KDEVPLATFORM_FOUND "kdevplatform" "The KDevPlatform libraries" "")
 
 add_definitions (${QT_DEFINITIONS} ${KDE4_DEFINITIONS})
 
-add_subdirectory(cmake)
 macro_optional_add_subdirectory (doc)
 
-if(LIBICECREAM_FOUND)
 	macro_optional_add_subdirectory (icemon)
-endif(LIBICECREAM_FOUND)
 
 macro_optional_add_subdirectory( binspekt )
 


[prev in list] [next in list] [prev in thread] [next in thread]