[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/graphics/kipi-plugins/removeredeyes
From:       Andi Clemens <andi.clemens () gmx ! net>
Date:       2010-11-15 1:44:56
Message-ID: 20101115014456.8E24EAC8A2 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1197153 by aclemens:

code polish (init lists etc)

 M  +1 -1      commonsettings.h  
 M  +5 -4      commonwidgets/controlwidget.cpp  
 M  +10 -8     commonwidgets/previewwidget.cpp  
 M  +5 -3      commonwidgets/storagesettingsbox.cpp  
 M  +11 -9     detection/locators/haarclassifier/haarsettings.h  
 M  +10 -5     detection/locators/haarclassifier/widgets/haarsettingswidget.cpp  
 M  +4 -3      plugin_removeredeyes.cpp  


--- trunk/extragear/graphics/kipi-plugins/removeredeyes/commonsettings.h \
#1197152:1197153 @@ -35,7 +35,7 @@
 {
 public:
 
-    CommonSettings() {};
+    CommonSettings() : addKeyword(true), storageMode(0), unprocessedMode(0) {};
 
     bool    addKeyword;
     int     storageMode;
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/commonwidgets/controlwidget.cpp \
#1197152:1197153 @@ -42,11 +42,12 @@
 
 struct ControlWidgetPriv
 {
-    ControlWidgetPriv()
+    ControlWidgetPriv() :
+        mode(0),
+        renderer(0),
+        timerFadeIn(0),
+        timerFadeOut(0)
     {
-        renderer     = 0;
-        timerFadeIn  = 0;
-        timerFadeOut = 0;
     }
 
     int           mode;
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/commonwidgets/previewwidget.cpp \
#1197152:1197153 @@ -45,15 +45,17 @@
 
 struct PreviewWidgetPriv
 {
-    PreviewWidgetPriv()
+    PreviewWidgetPriv() :
+        locked(false),
+        busyLabel(0),
+        noSelectionLabel(0),
+        originalLabel(0),
+        correctedLabel(0),
+        maskLabel(0),
+        stack(0),
+        controller(0),
+        modeInfo(0)
     {
-        busyLabel           = 0;
-        noSelectionLabel    = 0;
-        originalLabel       = 0;
-        correctedLabel      = 0;
-        maskLabel           = 0;
-        modeInfo            = 0;
-        controller          = 0;
     }
 
     bool                locked;
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/commonwidgets/storagesettingsbox.cpp \
#1197152:1197153 @@ -44,10 +44,12 @@
 
 struct StorageSettingsBoxPriv
 {
-    StorageSettingsBoxPriv()
+    StorageSettingsBoxPriv() :
+        keywordCB(0),
+        saveMethodCB(0),
+        keywordLineEdit(0),
+        saveMethodLineEdit(0)
     {
-        saveMethodLineEdit   = 0;
-        keywordLineEdit = 0;
     }
     QCheckBox*      keywordCB;
 
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/detection/locators/haarclassifier/haarsettings.h \
#1197152:1197153 @@ -43,16 +43,18 @@
     {
     public:
 
-        HaarSettings()
+        HaarSettings() :
+            useStandardClassifier(true),
+            useSimpleMode(true),
+            addKeyword(true),
+            minRoundness(0.0),
+            scaleFactor(0.0),
+            minBlobsize(0),
+            neighborGroups(0),
+            storageMode(0),
+            unprocessedMode(0),
+            simpleMode(0)
         {
-
-            useStandardClassifier = true;
-            useSimpleMode         = true;
-            minRoundness          = 0.0;
-            scaleFactor           = 0.0;
-            minBlobsize           = 0;
-            neighborGroups        = 0;
-            simpleMode            = 0;
         };
 
         void debug()
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/detection/locators/haarclassifier/widgets/haarsettingswidget.cpp \
#1197152:1197153 @@ -47,12 +47,13 @@
 
 struct SettingsTabPriv
 {
-    SettingsTabPriv()
+    SettingsTabPriv() :
+        simpleCorrectionMode(true),
+        settingsSwitcherBtn(0),
+        settingsStack(0),
+        advancedSettings(0),
+        simpleSettings(0)
     {
-        advancedSettings    = 0;
-        simpleSettings      = 0;
-        settingsSwitcherBtn = 0;
-        settingsStack       = 0;
     }
 
     bool                        simpleCorrectionMode;
@@ -154,9 +155,13 @@
 void HaarSettingsWidget::updateSettings()
 {
     if (d->simpleCorrectionMode)
+    {
         d->settings = d->simpleSettings->readSettings();
+    }
     else
+    {
         d->settings = d->advancedSettings->readSettings();
 }
+}
 
 } // namespace KIPIRemoveRedEyesPlugin
--- trunk/extragear/graphics/kipi-plugins/removeredeyes/plugin_removeredeyes.cpp \
#1197152:1197153 @@ -48,10 +48,9 @@
 K_EXPORT_PLUGIN ( RemoveRedEyesFactory("kipiplugin_removeredeyes") )
 
 Plugin_RemoveRedEyes::Plugin_RemoveRedEyes(QObject *parent, const QVariantList \
                &/*args*/)
-                    : KIPI::Plugin(RemoveRedEyesFactory::componentData(),
-                                   parent, "RemoveRedEyes")
+                    : KIPI::Plugin(RemoveRedEyesFactory::componentData(), parent, \
"RemoveRedEyes"), +                      m_action(0)
 {
-
     kDebug(AREA_CODE_LOADING) << "Plugin_RemoveRedEyes plugin loaded";
 }
 
@@ -101,7 +100,9 @@
 KIPI::Category Plugin_RemoveRedEyes::category(KAction* action) const
 {
     if (action == m_action)
+    {
         return KIPI::BatchPlugin;
+    }
 
     kWarning() << "Unrecognized action for plugin category identification";
     return KIPI::BatchPlugin; // no warning from compiler, please


[prev in list] [next in list] [prev in thread] [next in thread]