[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: Re: KDE/kdebase/workspace/kwin
From:       Ivan Cukic <ivan.cukic () kde ! org>
Date:       2010-11-14 10:13:15
Message-ID: 4cdfb642.147c0e0a.67da.0479 () mx ! google ! com
[Download RAW message or body]

> Are you sure that using no border is the right one here? That breaks 
> activities on the netbook shell... What you want is the Plasma stuff and there 

How does it break netbook shell? IIRC, nb shell doesn't use /these/ \
kactivitymanagerd-based activities. Unless  Marco did it recently.

> are probably some better set window classes like "plasma-desktop" to use than 

From my point of view, this would be evil - hardcoding 'plasma' into kwin (maybe it \
already is somewhere, but it still  is evil :) ). Especially because it is not \
sufficient - krunner (non 'plasma-desktop' winclass) is in the same group.

Maybe having something like KWindowSystem::setOnAllActivities(...) like we have for \
the desktops would provide  a valid solution. Or some window flag.

I'm open for all ideas (naturally), but without this patch (which inserted only the \
border clause), plasma-desktop  was activity-unusable.

> such a bogous behavior like no border. Just that Chromium is broken by using 
> CSD does not mean that it is unusable for activities.

The problem with all CSD apps is that users can't click the upper corner or \
right-click the caption bar to choose the  activity it should be on. And apart from a \
few /normal/ apps that are CSD (chromium, opera and similar) it is my  impression \
that most of them are some environment things - custom fancy docks, desktop overlays \
etc. which don't  depend on activities.

So, it behaves as well as it can since it is a heuristic-based check.

If we introduce some kind of method which will say 'I want to be on all activities', \
then the whole check can go  away.


Cheerio



-- 
Those people who think they know everything are a great annoyance to those of us who \
                do.
   -- Isaac Asimov


[prev in list] [next in list] [prev in thread] [next in thread]