[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/plasma
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-11-13 18:00:17
Message-ID: 201011131000.49242.aseigo () kde ! org
[Download RAW message or body]


On Saturday, November 13, 2010, Chani wrote:
> On November 12, 2010 23:51:31 Aaron J. Seigo wrote:
> > SVN commit 1196287 by aseigo:
> > 
> > * be sure to set kiosk-based immutability
> > * don't allow external creation of containments if the corona is
> > immutable; they won't get saved to disk anyways
> > 
> >  M  +14 -5     corona.cpp
> > 
> > --- trunk/KDE/kdelibs/plasma/corona.cpp #1196286:1196287
> > @@ -402,12 +402,12 @@
> > 
> >      }
> >      
> >      if (config()->isImmutable()) {
> > 
> > -        d->updateContainmentImmutability();
> > -    }
> > -
> > +        setImmutability(SystemImmutable);
> 
> is there any chance of this SystemImmutable getting written to the config?

no, i was quite careful about that.

> > @@ -606,14 +606,22 @@
> > 
> >  Containment *Corona::addContainment(const QString &name, const
> > 
> > QVariantList &args) {
> > +    if (d->immutability == Mutable) {
> > 
> >      return d->addContainment(name, args, 0, false);
> >  
> >  }
> 
> breaks creation of new activities that aren't from templates :)
> either give me a different method that plasmaapp can use, or revert that
> line.

whatever code is doing that is broken. that it worked at all was an accident 
of Corona::addContainment not sticking to the contract of immutability. 

what is the exact use case that is failing here?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]