[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdecore/services
From:       David Faure <faure () kde ! org>
Date:       2010-11-13 1:40:34
Message-ID: 20101113014034.AD5DAAC89E () svn ! kde ! org
[Download RAW message or body]

SVN commit 1196330 by dfaure:

Fix data race in KMimeType::sharedMimeInfoVersion(), detected by Dawit and confirmed by helgrind
BUG: adawit@kde.org


 M  +2 -0      kmimetype.cpp  


--- trunk/KDE/kdelibs/kdecore/services/kmimetype.cpp #1196329:1196330
@@ -713,6 +713,8 @@
 int KMimeType::sharedMimeInfoVersion()
 {
     static int s_version = 0;
+    static QMutex s_versionMutex;
+    QMutexLocker locker(&s_versionMutex);
     if (s_version == 0) {
         QProcess smi;
         const QString umd = KStandardDirs::findExe(QString::fromLatin1("update-mime-database"));
[prev in list] [next in list] [prev in thread] [next in thread]