[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/libs/flake
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2010-11-12 4:25:12
Message-ID: 20101112042512.82F4FAC89E () svn ! kde ! org
[Download RAW message or body]

SVN commit 1195841 by zachmann:

Correct Fix for bug 256624

The reason why the placeholders are shown is that they are not marked as placeholder \
which is a bug in OpenOffice and looks like MSOffice copied the wrong behaviour.

<draw:frame draw:id="id2" draw:name="Title Placeholder 8" presentation:class="title" \
presentation:placeholder="false" presentation:style-name="a13" svg:height="1.25in" \
svg:width="9in" svg:x="0.5in" svg:y="0.77in">

The presentation:placeholder should be true and not false if it is a placeholder.

This patch uses the same workaround as for OpenOffice

@Sebastian: please revert your commit 1195774

CCMAIL: sebsauer@kdab.com
BUG: 256624


 M  +2 -1      KoOdfWorkaround.cpp  


--- trunk/koffice/libs/flake/KoOdfWorkaround.cpp #1195840:1195841
@@ -190,7 +190,8 @@
 
 void KoOdfWorkaround::setFixPresentationPlaceholder(bool fix, KoShapeLoadingContext \
&context)  {
-    if (context.odfLoadingContext().generatorType() == \
KoOdfLoadingContext::OpenOffice) { +    KoOdfLoadingContext::GeneratorType \
type(context.odfLoadingContext().generatorType()); +    if (type == \
KoOdfLoadingContext::OpenOffice || type == KoOdfLoadingContext::MicrosoftOffice) {  \
s_workaroundPresentationPlaceholderBug = fix;  }
 }


[prev in list] [next in list] [prev in thread] [next in thread]