[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore
From:       David Faure <faure () kde ! org>
Date:       2010-11-09 20:23:26
Message-ID: 201011092123.27093.faure () kde ! org
[Download RAW message or body]

On Tuesday 09 November 2010, Christian Ehrlicher wrote:
> Am 09.11.2010 21:06, schrieb David Faure:
> > On Tuesday 09 November 2010, Christian Ehrlicher wrote:
> >> SVN commit 1194753 by chehrlic:
> >> 
> >> compile++
> > 
> > Ouch, I could have at least done a pass over the _win.cpp files visually.
> > Sorry for the additional work, and thanks for the fix.
> > 
> > I'm also guilty for the qbytearray usage which made you add this in
> > 
> > kstandarddirs.cpp:
> >      gethostname(hostname, 255);
> >      const QString localkdedir = m_prefixes.first();
> > 
> > +    // this will not work on windows when localkdedir contains
> > +    // characters not encodeable in the current locale
> > 
> >      QByteArray dir = QFile::encodeName(localkdedir);
> >      dir += type;
> >      dir += '-';
> > 
> > I forgot that the best representation of a path on Windows is a QString
> > (while on unix one could argue that it's qbytearray, but none of the qt
> > api takes that anyway).
> > 
> > Shall I change it back to QString?
> > 
> >   [with the risk to break compilation again, although I'll be careful :)]
> 
> It would be nice, yes :)

Hmm how does readlink() work then on Windows? Doesn't it take a char* like on 
Unix?

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]