[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore
From:       David Faure <faure () kde ! org>
Date:       2010-11-09 19:28:46
Message-ID: 201011092028.47148.faure () kde ! org
[Download RAW message or body]

On Tuesday 09 November 2010, John Layt wrote:
> SVN commit 1194746 by jlayt:
> Add KLocale method to return list of all installed KDE languages.
> Needed by new Locale KCM, mostly lifted from KLanguageCombo.
>
> --- trunk/KDE/kdelibs/kdecore/localization/klocale.h #1194745:1194746
> @@ -1848,6 +1848,18 @@
>      QStringList allLanguagesList() const;
> 
>      /**
> +     * Provides list of all installed KDE Language Translations.
> +     *
> +     * Use languageCodeToName(language) to get human readable, localized
> +     * language names.
> +     *
> +     * @return list of all installed language codes
> +     *
> +     * @see languageCodeToName
> +     */

@since 4.6 missing

> +    QStringList allLanguagesInstalledList() const;

The "List" at the end is a bit of a strange naming.
In proper English, wouldn't this be allInstalledLanguages(), or simply 
installedLanguages()?

> +void KLocaleTest::languages()
> +{
> +    kDebug() << KGlobal::locale()->allLanguagesInstalledList();
> +}

Not really a unit test ;)
But of course it's difficult to unit test here since it requires desktop files 
from kdebase. Maybe this test could be in kdebase...

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]