[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore
From:       David Faure <faure () kde ! org>
Date:       2010-11-08 12:12:31
Message-ID: 201011081312.31797.faure () kde ! org
[Download RAW message or body]

On Friday 05 November 2010, Oswald Buddenhagen wrote:
> On Fri, Nov 05, 2010 at 12:10:21AM +0100, David Faure wrote:
> > On Thursday 04 November 2010, Oswald Buddenhagen wrote:
> > > i think you are supposed to provide an efficient no-op implementation
> > > for the KDE_NO_DEBUG_OUTPUT case.
> > 
> > Good point.
> > Easy for that case (disabled at compile time),
> 
> you went only half the way (by emptying the macro). i think an entirely
> empty class should be added as well.

Good point, done.

> one thing i'm wondering about: the locking of the indent string. when
> two threads start accessing it at the same time, things will turn into
> an utter mess anyway. so one could either keep the lock for the whole
> lifetime of the block (which may have rather severe side effects), or
> one could put the indent string into thread-local storage.

Good point, used a thread-local storage.

Thanks.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]