[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/plugins/chartshape
From:       Johannes Simon <johannes.simon () gmail ! com>
Date:       2010-11-07 15:58:24
Message-ID: 0A6B0C59-6B1C-44F0-9B92-4F80D55900EE () gmail ! com
[Download RAW message or body]

Gracias.

Am 07.11.2010 um 16:46 schrieb Boudewijn Rempt:

> SVN commit 1193938 by rempt:
> 
> fix warning (unused parameters)
> 
> M  +2 -2      ChartProxyModel.cpp  
> M  +3 -2      ChartShape.cpp  
> M  +1 -1      ChartTableModel.cpp  
> M  +1 -1      KDChartModel.cpp  
> M  +2 -2      PlotArea.cpp  
> M  +4 -4      tests/ModelObserver.cpp  
> 
> 
> --- trunk/koffice/plugins/chartshape/ChartProxyModel.cpp #1193937:1193938
> @@ -633,13 +633,13 @@
> return QModelIndex();
> }
> 
> -int ChartProxyModel::rowCount( const QModelIndex &parent /* = QModelIndex() */ ) \
> const +int ChartProxyModel::rowCount( const QModelIndex &/*parent  = QModelIndex() \
> */ ) const {
> return d->dataSets.count();
> }
> 
> 
> -int ChartProxyModel::columnCount( const QModelIndex &parent /* = QModelIndex() */ \
> ) const +int ChartProxyModel::columnCount( const QModelIndex &/*parent = \
> QModelIndex() */ ) const {
> // FIXME: Replace this by the actual column count once the proxy is properly being \
> used. return INT_MAX;
> --- trunk/koffice/plugins/chartshape/ChartShape.cpp #1193937:1193938
> @@ -258,9 +258,10 @@
> 
> 
> ChartShape::Private::Private( ChartShape *shape )
> -    : internalModel(0),
> -    resourceManager(0)
> +    : internalModel(0)
> , internalModelHelper( 0 )
> +    , resourceManager(0)
> +
> {
> // Register the owner.
> this->shape = shape;
> --- trunk/koffice/plugins/chartshape/ChartTableModel.cpp #1193937:1193938
> @@ -65,7 +65,7 @@
> return QHash<QString, QVector<QRect> >();
> }
> 
> -bool ChartTableModel::setCellRegion( const QString& regionName )
> +bool ChartTableModel::setCellRegion( const QString& /*regionName*/ )
> {
> #if 0 // FIXME: What does this code do?
> int result = 0;
> --- trunk/koffice/plugins/chartshape/KDChartModel.cpp #1193937:1193938
> @@ -264,7 +264,7 @@
> emit headerDataChanged( dataDirection(), first, last );
> }
> 
> -void KDChartModel::dataSetChanged( DataSet *dataSet, DataRole role, int first /* = \
> -1 */, int last /* = -1 */ ) +void KDChartModel::dataSetChanged( DataSet *dataSet, \
> DataRole /*role*/, int first /* = -1 */, int last /* = -1 */ ) {
> Q_ASSERT( d->dataSets.contains( dataSet ) );
> if ( !d->dataSets.contains( dataSet ) )
> --- trunk/koffice/plugins/chartshape/PlotArea.cpp #1193937:1193938
> @@ -238,7 +238,7 @@
> }
> // There need to be at least these two axes. Do not delete, but
> // hide them instead.
> -    Axis *xAxis = new Axis( q, XAxisDimension );
> +//    Axis *xAxis = new Axis( q, XAxisDimension );
> Axis *yAxis = new Axis( q, YAxisDimension );
> yAxis->setShowMajorGrid( true );
> }
> @@ -606,7 +606,7 @@
> 
> loadOdfAttributes( plotAreaElement, context, OdfAllAttributes );
> 
> -    OdfLoadingHelper *helper = (OdfLoadingHelper*)context.sharedData( \
> OdfLoadingHelperId ); +//    OdfLoadingHelper *helper = \
> (OdfLoadingHelper*)context.sharedData( OdfLoadingHelperId ); 
> // First step is to load the axis. Datasets are attached to an
> // axis and we need the axis to check for categories.
> --- trunk/koffice/plugins/chartshape/tests/ModelObserver.cpp #1193937:1193938
> @@ -47,7 +47,7 @@
> this,   SLOT( slotModelReset() ) );
> }
> 
> -void ModelObserver::slotRowsInserted( const QModelIndex & parent, int start, int \
> end ) +void ModelObserver::slotRowsInserted( const QModelIndex & /*parent*/, int \
> start, int end ) {
> Q_ASSERT( start <= end );
> 
> @@ -56,7 +56,7 @@
> qDebug() << "m_numRows: " << m_numRows;
> }
> 
> -void ModelObserver::slotColumnsInserted( const QModelIndex & parent, int start, \
> int end ) +void ModelObserver::slotColumnsInserted( const QModelIndex & /*parent*/, \
> int start, int end ) {
> Q_ASSERT( start <= end );
> 
> @@ -65,7 +65,7 @@
> qDebug() << "m_numCols: " << m_numCols;
> }
> 
> -void ModelObserver::slotRowsRemoved( const QModelIndex & parent, int start, int \
> end ) +void ModelObserver::slotRowsRemoved( const QModelIndex & /*parent*/, int \
> start, int end ) {
> Q_ASSERT( start <= end );
> Q_ASSERT( end < m_numRows );
> @@ -75,7 +75,7 @@
> qDebug() << "m_numRows: " << m_numRows;
> }
> 
> -void ModelObserver::slotColumnsRemoved( const QModelIndex & parent, int start, int \
> end ) +void ModelObserver::slotColumnsRemoved( const QModelIndex & /*parent*/, int \
> start, int end ) {
> Q_ASSERT( start <= end );
> Q_ASSERT( end < m_numCols );


[prev in list] [next in list] [prev in thread] [next in thread]