[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/krita/image
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-11-07 8:40:36
Message-ID: 20101107084037.03EF3AC89B () svn ! kde ! org
[Download RAW message or body]

SVN commit 1193814 by dkazakov:

Deprecate KisImage::mergedImage() function

It is intended to do a very strange thing (it doesn't guarantee
anything, because it can't even lock the image) and its functionality is
fully covered by other methods of KisImage. See a comment in the
header to get more info.


 M  +13 -5     kis_image.h  


--- trunk/koffice/krita/image/kis_image.h #1193813:1193814
@@ -371,12 +371,20 @@
     }
 
     /**
-     * returns a paintdevice that contains the merged layers of this
-     * image, within the bounds of this image (with the colorspace and
-     * profile of this image) It will cause a synchronous update to the
-     * projection.
+     * Starting form 2.3 mergedImage() is declared deprecated.
+     * If you want to get a projection of the image, please use
+     * something like:
+     *
+     * image->lock();
+     * read_something_from_the_image(image->projection());
+     * image->unlock();
+     *
+     * or if you want to get a full refresh of the image graph
+     * performed beforehand (do you really want it?) (sure?) then
+     * you can add a call to image->refreshGraph() before locking
+     * the image.
      */
-    KisPaintDeviceSP mergedImage();
+    KDE_DEPRECATED KisPaintDeviceSP mergedImage();
 
     /**
      * @return the root node of the image node graph
[prev in list] [next in list] [prev in thread] [next in thread]