[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kate/buffer
From:       Christoph Cullmann <cullmann () kde ! org>
Date:       2010-11-06 18:34:43
Message-ID: 20101106183443.04CE1AC89B () svn ! kde ! org
[Download RAW message or body]

SVN commit 1193679 by cullmann:

mwolff:
    opt: save us one more call to .contains() and use a non-detaching .at() instead of operator[]



 M  +3 -4      katetextblock.cpp  


--- trunk/KDE/kdelibs/kate/buffer/katetextblock.cpp #1193678:1193679
@@ -587,7 +587,8 @@
   /**
    * cached range?
    */
-  if (m_cachedLineForRanges.contains(range)) {
+  QHash<TextRange*, int>::iterator it = m_cachedLineForRanges.find(range);
+  if (it != m_cachedLineForRanges.end()) {
     /**
      * must be only cached!
      */
@@ -596,9 +597,7 @@
     /**
      * query the range from cache, must be there
      */
-    QHash<TextRange*, int>::iterator it = m_cachedLineForRanges.find(range);
-    Q_ASSERT (it != m_cachedLineForRanges.end());
-    Q_ASSERT (m_cachedRangesForLine[*it].contains(range));
+    Q_ASSERT (m_cachedRangesForLine.at(*it).contains(range));
     
     /**
      * remove it and be done
[prev in list] [next in list] [prev in thread] [next in thread]