[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdecore/io
From:       David Faure <faure () kde ! org>
Date:       2010-11-06 2:13:59
Message-ID: 20101106021359.96A7BAC89B () svn ! kde ! org
[Download RAW message or body]

SVN commit 1193441 by dfaure:

- add some thinking about qfswatch based on today's irc discussion
- fix compilation with NDEBUG


 M  +6 -0      kdirwatch.cpp  


--- trunk/KDE/kdelibs/kdecore/io/kdirwatch.cpp #1193440:1193441
@@ -83,6 +83,10 @@
   return dwp_self;
 }
 
+// Should we default to QFSWatch?
+// Pro: supports kqueue on BSD (pending MR 2425), supports symbian etc.
+// Con: does not support FAM, i.e. breaks with NFS mounts on linux where it only \
uses inotify +//  -> nfsPreferredMethod could default to fam [fallbacks to stat], \
actually...  
 // Convert a string into a watch Method
 static KDirWatch::Method methodFromString(const QString& method) {
@@ -234,7 +238,9 @@
   availableMethods << "QFileSystemWatcher";
   fsWatcher = 0;
 #endif
+#ifndef NDEBUG
   kDebug(7001) << "Available methods: " << availableMethods << "preferred=" << \
methodToString(m_preferredMethod); +#endif
 }
 
 // This is called on app exit (when K_GLOBAL_STATIC deletes KDirWatch::self)


[prev in list] [next in list] [prev in thread] [next in thread]