[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/kdepim/enterprise4/kdepim/kleopatra/commands
From:       Marc Mutz <mutz () kde ! org>
Date:       2010-11-03 12:25:25
Message-ID: 20101103122525.7B210AC89B () svn ! kde ! org
[Download RAW message or body]

SVN commit 1192596 by mutz:

LearnCardKeysCommand: don't use postSuccessHook()

The postSuccessHook() isn't called when a Command ignoresSuccessOrFailure().
Simply connect the ReaderStatus::updateStatus() slot to the Command::finished()
signal.

Fixes kolab/issue4519 (c).

 M  +2 -4      learncardkeyscommand.cpp  
 M  +0 -1      learncardkeyscommand.h  


--- branches/kdepim/enterprise4/kdepim/kleopatra/commands/learncardkeyscommand.cpp #1192595:1192596
@@ -54,6 +54,8 @@
 {
     setIgnoresSuccessOrFailure( true );
     setShowsOutputWindow( true );
+    connect( this, SIGNAL(finished()),
+             SmartCard::ReaderStatus::mutableInstance(), SLOT(updateStatus()) );
 }
 
 LearnCardKeysCommand::~LearnCardKeysCommand() {}
@@ -94,8 +96,4 @@
     return QString();
 }
 
-void LearnCardKeysCommand::postSuccessHook( QWidget * ) {
-    SmartCard::ReaderStatus::mutableInstance()->updateStatus();
-}
-
 #include "moc_learncardkeyscommand.cpp"
--- branches/kdepim/enterprise4/kdepim/kleopatra/commands/learncardkeyscommand.h #1192595:1192596
@@ -60,7 +60,6 @@
         /* reimp */ QString errorExitMessage( const QStringList & ) const;
         /* reimp */ QString successMessage( const QStringList & ) const;
 
-        /* reimp */ void postSuccessHook( QWidget * );
     private:
         GpgME::Protocol m_protocol;
     };
[prev in list] [next in list] [prev in thread] [next in thread]