[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/koffice-essen/filters/libmsooxml
From:       Marijn Kruisselbrink <marijn.kruisselbrink () kogmbh ! com>
Date:       2010-10-29 17:11:23
Message-ID: 201010291011.23755.marijn.kruisselbrink () kogmbh ! com
[Download RAW message or body]

On Friday, October 29, 2010 02:28:52 am Inge Wallin wrote:
> On Tuesday, October 26, 2010 03:00:12 Marijn Kruisselbrink wrote:
> > SVN commit 1189832 by mkruisselbrink:
> > 
 
> Hmm, these values are incompatible with the numbers in your very next
> patch:
> 
> [...]
>
> Should they perhaps be stored somewhere global so that both kspread and all
> filters can use the same number?
Well, that one is actually the one that is correct; the ooxml filter expect a 
row/column count, while kspread has a maximum row/column id (and uses 1-based 
indices), but yeah, the 0x7FFF is then indeed wrong for the maximum column 
index.
And yeah, this should probably be shared, but for some reason the limits for 
the xlsx filter are in libmsooxml (even though only the xlsx filter uses them), 
and I didn't want to make libmsooxml build-time depend on kspread_limits.h

Marijn
[prev in list] [next in list] [prev in thread] [next in thread]