[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kate
From:       David Faure <faure () kde ! org>
Date:       2010-10-28 12:29:53
Message-ID: 201010281429.54256.faure () kde ! org
[Download RAW message or body]

On Thursday 28 October 2010, Bernhard Beschow wrote:
> --- trunk/KDE/kdelibs/kate/search/katesearchbar.h #1190633:1190634
> @@ -157,7 +157,6 @@
>      KateViewConfig *const m_config;
>      QList<KTextEditor::MovingRange*> m_hlRanges;
>  
> -private:
>      // Shared by both dialogs
>      QVBoxLayout *const m_layout;
>      QWidget * m_widget;

Well, the class is not exported, but still, making all member variables 
protected makes further refactoring of the class rather difficult, since one has 
to always check if the member vars are used somewhere else...
If this is just for the unit test, why not add "friend class SearchBarTest;"?

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]